[Fix] Copy commandFactory when creating DatabricksClient for unified provider#5503
Merged
Divyansh-db merged 1 commit intomainfrom Mar 20, 2026
Conversation
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
tanmay-db
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix getDatabricksClientForUnifiedProvider not copying commandFactory
Summary
*client.DatabricksClient — it does not copy commandFactory, causing a nil pointer panic when resources call CommandExecutor()
Root Cause
getDatabricksClientForUnifiedProvider constructs the returned client as:
return &DatabricksClient{
DatabricksClient: client,
// commandFactory is missing!
}, nil
CommandExecutor() calls c.commandFactory(ctx, c), which panics when commandFactory is nil.
This bug was latent on main because resources using DatabricksClientForUnifiedProvider with a workspace-level provider always got workspaceID == "" from
state, short-circuiting to return the original client (which has commandFactory). The bug is only triggered when provider_config { workspace_id } is
explicitly set, routing through getDatabricksClientForUnifiedProvider.
Test plan
NO_CHANGELOG=true